| From: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(at)vondra(dot)me>, Andres Freund <andres(at)anarazel(dot)de>, Bernd Helmle <mailings(at)oopsware(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Changing the state of data checksums in a running cluster |
| Date: | 2026-04-08 07:31:13 |
| Message-ID: | CAHg+QDfRk4-S7DMmdbXJnQ-xF=sUpMAKuh8b83ObLqYVKx5QLA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Daniel,
On Fri, Apr 3, 2026 at 8:33 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> The attached rebase with a PG_CONTROL_VERSION bump is what I have staged
> for
> later tonight, submitting here to have the (hopefully) final patch
> archived as
> well as another CFBot run.
>
Sorry for the late review. pg_enable/disable_data_checksums() aren't needed
to be run
on the standby. It appears the call would silently register a dynamic
background worker that
could never start , and could unexpectedly fire after promotion.
Please find the attached patch to address this.
Thanks,
Satya
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Prevent-pg_enable-disable_data_checksums-on-standby.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-04-08 07:31:55 | Re: Adding REPACK [concurrently] |
| Previous Message | Alexander Korotkov | 2026-04-08 07:31:07 | Re: Implement waiting for wal lsn replay: reloaded |