| From: | Manu <manuelreyesbravo(at)gmail(dot)com> |
|---|---|
| To: | Raja Sai pranav <rajasaipranav0(at)gmail(dot)com> |
| Cc: | zhong950419(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, masaofujii(at)gmail(dot)com, darianlepikhova(at)gmail(dot)com, ayushtiwarislg01(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Assertion failure in WAL summarizer |
| Date: | 2026-11-11 05:40:00 |
| Message-ID: | 179437560064.1135895.4554950945044577493@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Shihao and Sai,
On Tue, Nov 10, 2026 at 8:00 PM Raja Sai pranav
<rajasaipranav0(at)gmail(dot)com> wrote:
> With all three patches applied, every test passes (pg_combinebackup
> 147/147, pg_walsummary 34/34, on an assert-enabled build).
Thanks, Shihao, for the rebase, and Sai for the two rounds of testing.
I got the same on master as of 952bab8b74d, and I also built it with
meson and clang, as CFbot does: no warnings, and the 23 tests of
pg_walsummary and pg_combinebackup pass. pgindent changes nothing.
One small thing: the commit message of 0003 still names
t/014_summary_past_switch.pl and t/015_truncation_after_target.pl.
Since b5545d3f5f9 took t/014 in pg_combinebackup, they are now
t/015_summary_past_switch.pl and t/016_truncation_after_target.pl.
Regards,
Manu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-11-11 05:53:25 | RE: [PATCH] Explain what the default output_plugin_libraries do |
| Previous Message | shveta malik | 2026-11-11 05:29:59 | Re: Crashes on a partition whose concurrent detach never finished |