Re: Avoid recalculating pgprocno in ProcArrayAdd()

Hello,

I have have applied the patch in a branch, rebuild (/configure --prefix=$TARGET --enable-cassert --enable-debug --with-uuid=e2fs --with-openssl --enable-tap-tests
) and installed locally postgreSQL with:

Running make check is OK but make installcheck-world fails with :

# +++ tap install-check in src/test/postmaster +++
t/001_basic.pl .............. ok
t/002_connection_limits.pl .. ok
t/003_start_stop.pl ......... ok
t/004_negotiate.pl .......... ok
All tests successful.
Files=4, Tests=67, 3 wallclock secs ( 0.01 usr 0.01 sys + 1.37 cusr 0.75 csys = 2.14 CPU)
Result: PASS
make[2] : on quitte le répertoire « /var/lib/postgresql/postgresql/src/test/postmaster »
make -C recovery installcheck
make[2] : on entre dans le répertoire « /var/lib/postgresql/postgresql/src/test/recovery »
echo "# +++ tap install-check in src/test/recovery +++" && rm -rf '/var/lib/postgresql/postgresql/src/test/recovery'/tmp_check && /usr/bin/mkdir -p '/var/lib/postgresql/postgresql/src/test/recovery'/tmp_check && cd . && TESTLOGDIR='/var/lib/postgresql/postgresql/src/test/recovery/tmp_check/log' TESTDATADIR='/var/lib/postgresql/postgresql/src/test/recovery/tmp_check' PATH="/var/lib/pgsql/local/bin:/var/lib/postgresql/postgresql/src/test/recovery:$PATH" PGPORT='65432' top_builddir='/var/lib/postgresql/postgresql/src/test/recovery/../../..' PG_REGRESS='/var/lib/postgresql/postgresql/src/test/recovery/../../../src/test/regress/pg_regress' share_contrib_dir='/var/lib/pgsql/local/share/' /usr/bin/prove -I ../../../src/test/perl/ -I . t/*.pl
# +++ tap install-check in src/test/recovery +++
t/001_stream_rep.pl ................... ok
t/002_archiving.pl .................... ok
t/003_recovery_targets.pl ............. ok
t/004_timeline_switch.pl .............. ok
t/005_replay_delay.pl ................. ok
t/006_logical_decoding.pl ............. # die: error running SQL: 'psql:<stdin>:1: ERROR: could not access file "test_decoding": No such file or directory'
# while running 'psql --no-psqlrc --no-align --tuples-only --quiet --dbname port=32144 host=/tmp/6cO_dufONc dbname='postgres' --file - --variable ON_ERROR_STOP=1' with sql 'SELECT pg_create_logical_replication_slot('test_slot', 'test_decoding');' at t/006_logical_decoding.pl line 28.
t/006_logical_decoding.pl ............. skipped: (no reason given)
t/007_sync_rep.pl ..................... ok
t/008_fsm_truncation.pl ............... ok
t/009_twophase.pl ..................... ok
t/010_logical_decoding_timelines.pl ... # die: error running SQL: 'psql:<stdin>:1: ERROR: could not access file "test_decoding": No such file or directory'
# while running 'psql --no-psqlrc --no-align --tuples-only --quiet --dbname port=20076 host=/tmp/CKHZu0kyi9 dbname='postgres' --file - --variable ON_ERROR_STOP=1' with sql 'SELECT pg_create_logical_replication_slot('before_basebackup', 'test_decoding');' at t/010_logical_decoding_timelines.pl line 52.
t/010_logical_decoding_timelines.pl ... skipped: (no reason given)
t/012_subtransactions.pl .............. ok
t/013_crash_restart.pl ................ Bailout called. Further testing stopped: pg_ctl start failed
t/013_crash_restart.pl ................ Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run

Test run interrupted!

Test Summary Report
-------------------
t/006_logical_decoding.pl (Wstat: 7424 (exited 29) Tests: 0 Failed: 0)
Non-zero exit status: 29
t/010_logical_decoding_timelines.pl (Wstat: 7424 (exited 29) Tests: 0 Failed: 0)
Non-zero exit status: 29
t/013_crash_restart.pl (Wstat: 65280 (exited 255) Tests: 0 Failed: 0)
Non-zero exit status: 255
Parse errors: No plan found in TAP output

What should I do ?

The new status of this patch is: Needs review