| From: | solai v <solai(dot)cdac(at)gmail(dot)com> |
|---|---|
| To: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Avoid recalculating pgprocno in ProcArrayAdd() |
| Date: | 2026-07-01 11:03:58 |
| Message-ID: | CAF0whuc=pXqiSBS8nbCpY=1_mVSEM9rgHe7gYsj5ROemZ7GChw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
On Wed, Jul 1, 2026 at 4:24 PM Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
>
> On Thu, Feb 12, 2026 at 10:41 AM Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
> > Thank you for the review! I've updated the commit message and I'll
> > mark it as Ready for Committer if there are no objections.
>
> I've marked it as Ready for committer.
>
I reviewed the patch and confirmed that it replaces the redundant call
to GetNumberFromPGProc(proc) with the pre-computed pgprocno. The
change does not alter any behavior and seems to be an efficient way of
code cleanup. Patch build successfully and regression tests passed.
The patch looks good to me.
Regards,
Solai
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2026-07-01 11:05:26 | Re: Refactor function pg_get_multixact_stats (src/backend/utils/adt/multixactfuncs.c) |
| Previous Message | Michael Paquier | 2026-07-01 10:54:23 | Re: Refactor function pg_get_multixact_stats (src/backend/utils/adt/multixactfuncs.c) |