| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: adt Makefile, was Re: jsonb and nested hstore |
| Date: | 2014-02-06 16:33:15 |
| Message-ID: | 17618.1391704395@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 02/01/2014 05:20 PM, Andres Freund wrote:
>> Odd, most OBJS lines are kept in alphabetical order, but that doesn't
>> seem to be the case here.
> This whole list is a mess, and we don't even have all the range_types
> files following each other.
> Worth cleaning up?
+1. It's just neatnik-ism, but isn't compulsive neatnik-ism pretty
much a job requirement for programmers? It's hard enough dealing
with necessary complexities without having to wonder if some seemingly
arbitrary choice has hidden meanings.
> I'm actually wondering if it might be worth having some subgroups of
> object files and then combining them into $OBJS.
Nah, let's just alphabetize them and be done. The Makefile has no
reason to care about subgroups of those files.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-02-06 16:38:28 | Re: adt Makefile, was Re: jsonb and nested hstore |
| Previous Message | PostgreSQL - Hans-Jürgen Schönig | 2014-02-06 16:31:48 | Re: Small GIN optimizations (after 9.4) |