Re: On /*----- comments

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: On /*----- comments
Date: 2023-06-30 15:22:15
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> Except for the translator comments, I think those others forgot about
> the end-guards by accident. But they look just as nice to me. It's
> probably not worth the code churn to remove them from existing comments,
> but how about we stop requiring them in new code, and update the
> pgindent README accordingly?

Seems reasonable; the trailing dashes eat a line without adding much.

Should we also provide specific guidance about how many leading dashes
to use for this? I vaguely recall that pgindent might only need one,
but I think using somewhere around 5 to 10 looks better.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2023-06-30 15:36:40 Re: XLog size reductions: Reduced XLog record header size for PG17
Previous Message Heikki Linnakangas 2023-06-30 15:07:16 On /*----- comments