Re: coerce_type discard unnecessary CollateExprs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: coerce_type discard unnecessary CollateExprs
Date: 2026-06-29 13:38:08
Message-ID: 1693552.1782740288@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

jian he <jian(dot)universality(at)gmail(dot)com> writes:
> Only the topmost CollateExpr will be used, all others will be dropped.
> We can apply this to coerce_type also.
> See the attached minor patch.

It's not apparent to me that this does anything (will there ever
be a CollateExpr at this stage?), or that it's correct if it does.
Please provide an example. Not to mention a comment.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Akshay Joshi 2026-06-29 13:38:11 Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements
Previous Message Peter Eisentraut 2026-06-29 13:27:18 Re: FOR PORTION OF should not allow WHERE CURRENT OF