Re: Two small patches for the isolationtester lexer

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Two small patches for the isolationtester lexer
Date: 2018-02-28 22:01:08
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> On 22 Feb 2018, at 05:10, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Actually, looking closer, this would also trigger on '#' used inside a
>> SQL literal, which seems to move the problem cases into the "pretty
>> likely" category instead of the "far-fetched" one. So I'd only be OK
>> with it if we made the lexer smart enough to distinguish inside-a-SQL-
>> literal from not. That might be a good thing anyway, since it would
>> allow us to not choke on literals containing '}', but it'd be a great
>> deal more work. You might be able to steal code from the psql lexer
>> though.

> I agree, patch 0002 was broken and the correct fix is a much bigger project -
> one too big for me to tackle right now (but hopefully at some point in the near
> future). Thanks for the review of it though!

OK. I'm going to mark this commitfest entry closed, since the other patch
is in and this one needs a good bit more work. Please start a new thread,
or at least a new CF entry, if you do more work in this area.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2018-02-28 22:13:44 Re: RFC: Add 'taint' field to pg_control.
Previous Message Tom Lane 2018-02-28 21:59:34 Re: Two small patches for the isolationtester lexer