From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Two small patches for the isolationtester lexer |
Date: | 2018-02-28 21:59:34 |
Message-ID: | 16409.1519855174@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 22 Feb 2018, at 05:12, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Another idea is just to teach addlitchar to realloc the buffer bigger
>> when necessary.
> I think this is the best approach for the task, the attached patch changes the
> static allocation to instead realloc when required. Having an upper limit on
> the allocation seemed like a good idea to me, but perhaps it’s overthinking and
> complicating things for no good reason.
Yeah, it doesn't seem to me that we need any fixed limit on the length,
so I deleted that part of the logic, and pushed it with one or two other
cosmetic adjustments.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-02-28 22:01:08 | Re: Two small patches for the isolationtester lexer |
Previous Message | Nikita Glukhov | 2018-02-28 21:58:42 | Re: [HACKERS] [PATCH] kNN for SP-GiST |