Re: Do quoting more carefully in replication commands

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
> In a quick skim, I wondered about this bit:

>> + * Caution: this quoting logic is sufficient for identifiers and literals
>> + * in the replication grammar, but not always in regular SQL. Specifically,
>> + * it'd fail for a string literal if standard_conforming_strings is off.

> ... given that standard_conforming_strings can no longer be off in 19.
> The backpatched version should surely still have this, just in case, but
> in 19 it's probably not needed.

There are assorted places in the backend that want to generate SQL
that will work against older versions. I don't think we can forget
about standard_conforming_strings until all those versions are off
even the support-back-to list, ie about 10 years from now.

regards, tom lane