Re: "has_column_privilege()" issue with attnums and non-existent columns

From: Chengxi Sun <sunchengxi(at)highgo(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Ian Barwick <barwick(at)gmail(dot)com>
Subject: Re: "has_column_privilege()" issue with attnums and non-existent columns
Date: 2021-03-16 05:42:49
Message-ID: 161587336958.28624.5988326766805492214.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested

I tested the patch and it works well. And according to the comment,
checking existence of relation and pg_class_aclcheck() won't influenced by concurrent DROP.
So I think it's safe to just reorder the checking existence of column and pg_attribute_aclcheck().

Thanks

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-03-16 05:46:08 Re: [HACKERS] Custom compression methods
Previous Message Amit Langote 2021-03-16 05:13:50 Re: Allow batched insert during cross-partition updates