From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | John Gorman <johngorman2(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Compile warnings on OSX 10.10 clang 6.0 |
Date: | 2015-04-03 21:01:54 |
Message-ID: | 1600.1428094914@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On 4/3/15 4:02 PM, John Gorman wrote:
>> I am getting compile warnings on OSX 10.10 from clang 6.0:
>>
>> clang: warning: argument unused during compilation: '-pthread'
>>
>> The 5 warnings are where we are making a -dynamiclib and
>> the -pthread argument is not necessary:
>>
>> ./src/interfaces/libpq/
>> ./src/interfaces/ecpg/pgtypeslib/
>> ./src/interfaces/ecpg/ecpglib/
>> ./src/interfaces/ecpg/compatlib/
>> ./src/interfaces/ecpg/preproc/
>>
>> This is interfering with using "-Wall -Werror" to catch warnings.
>>
>> Any opinions as to whether this is worth fixing and if so
>> what the cleanest approach might be?
> These warnings also happen with older versions of clang. Now idea how
> to fix yet. I'm thinking that clang should be fixed, because these
> warnings are stupid.
Yeah, they're utterly stupid; whoever put them in obviously doesn't
have a clue about typical Makefile construction. I wonder if next
we'll see complaints about unnecessary -D or -I switches.
Having said that, I did look awhile ago about how we might get rid of
them, and it seems not easy; for starters we would need to drop the
assumption that CFLAGS can always be included when linking. Also,
AFAICT -pthread sometimes *is* required when linking; so it's
not even very obvious when to suppress the switch, even if we could
do so without wholesale rearrangement of our FLAGS handling.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-04-03 21:21:12 | Re: Compile warnings on OSX 10.10 clang 6.0 |
Previous Message | Tom Lane | 2015-04-03 20:50:46 | Re: Unused variable in hashpage.c |