Re: expanding inheritance in partition bound order

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Beena Emerson <memissemerson(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: expanding inheritance in partition bound order
Date: 2017-08-16 01:26:13
Message-ID: 15fe1658-3c5f-e13e-1a14-89e9b83d8e9a@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/08/10 18:52, Beena Emerson wrote:
> Hi Amit,
>
> On Thu, Aug 10, 2017 at 7:41 AM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> On 2017/08/05 2:25, Robert Haas wrote:
>>> Concretely, my proposal is:
>>>
>>> P.S. While I haven't reviewed 0002 in detail, I think the concept of
>>> minimizing what needs to be built in RelationGetPartitionDispatchInfo
>>> is a very good idea.
>>
>> I put this patch ahead in the list and so it's now 0001.
>>
>
> FYI, 0001 patch throws the warning:
>
> execMain.c: In function ‘ExecSetupPartitionTupleRouting’:
> execMain.c:3342:16: warning: ‘next_ptinfo’ may be used uninitialized
> in this function [-Wmaybe-uninitialized]
> next_ptinfo->parentid != ptinfo->parentid)

Thanks for the review. Will fix in the updated version of the patch I
will post sometime later today.

Regards,
Amit

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Moon Insung 2017-08-16 01:33:23 Re: [PATCH] pageinspect function to decode infomasks
Previous Message Peter Eisentraut 2017-08-16 01:15:24 Re: replication_slot_catalog_xmin not explicitly initialized when creating procArray