From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Improvement in log message of logical replication worker |
Date: | 2017-05-18 02:29:06 |
Message-ID: | 15ab93f0-e869-7fa4-da13-2d7269d1a684@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 5/12/17 00:30, Masahiko Sawada wrote:
> I got same log messages 'starting logical replication worker for
> subscription' total 5 times but actually 4 of them mean to launch
> table sync worker and another one means apply worker. We cannot
> distinguish them. Also, I got same log messages 'logical replication
> synchronization worker finished processing' total 4 times but I think
> it's better to show the table name in finish log message as well. Any
> thoughts?
Yeah, that's quite a lot of messages for normal operation. I've been
playing around with it a little bit and came up with the attached patch
that produced a slightly reduced log volume and more consistent messages.
I think we don't need a message from the launcher that it will launch a
worker and then the worker also reporting that it started, so I
downgraded the former to DEBUG1. A more radical solution would be to
downgrade all these messages to DEBUG1.
We want to avoid showing OIDs in user-facing messages, but it's not
always easy to look up the names. See the patch for one solution.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Improve-logical-replication-worker-log-messages.patch | invalid/octet-stream | 2.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2017-05-18 02:50:42 | Re: Server Crashes if try to provide slot_name='none' at the time of creating subscription. |
Previous Message | Michael Paquier | 2017-05-18 02:25:55 | Re: Race conditions with WAL sender PID lookups |