Re: Add progressive backoff to XactLockTableWait functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Kevin K Biju <kevinkbiju(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add progressive backoff to XactLockTableWait functions
Date: 2025-08-07 18:20:33
Message-ID: 1593356.1754590833@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Xuneng Zhou <xunengzhou(at)gmail(dot)com> writes:
> V9 replaces the original partitioned xid-wait htab with a single,
> unified one, reflecting the modest entry count and rare contention for
> waiting. To prevent possible races when multiple backends wait on the
> same XID for the first time in XidWaitOnStandby, a dedicated lock has
> been added to protect the hash table.

This seems like adding quite a lot of extremely subtle code in
order to solve a very small problem. I thought the v1 patch
was about the right amount of complexity.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-08-07 20:04:17 Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events
Previous Message Jacob Champion 2025-08-07 18:19:21 Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events