Re: pgsql/src/interfaces/libpq (Makefile)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/src/interfaces/libpq (Makefile)
Date: 2000-10-21 23:56:58
Message-ID: 1575.972172618@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> (One might wonder why bother about this: it's because users might try to
> run, e.g., "make all CFLAGS=-O99 -mfoo" etc., so you have to forcibly hold
> on to the necessary CFLAGS as well. Yeah, I know, COPT -- but who's ever
> heard of that?)

That's a fairly unconvincing example, since the likely result would be
settings CFLAGS to "-O99 ... -O2 ...", thus preventing the user from
getting what he wants. Given that we do not know how "override" really
behaves (except that it's not like the manual), nor how consistently
it behaves across different versions of gmake, I think that it would be
far smarter to avoid "override" completely.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian - CVS 2000-10-22 05:14:02 pgsql/src/backend/catalog (catalog.c)
Previous Message Peter Eisentraut - PostgreSQL 2000-10-21 22:36:15 pgsql/src/template (aix beos bsdi dgux freebsd hpux irix5 linux netbsd openbsd osf qnx4 sco solaris sunos4 svr4 ultrix4 univel unixware win)