Re: TAP tests for pg_verify_checksums

From: Michael Banck <michael(dot)banck(at)credativ(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: TAP tests for pg_verify_checksums
Date: 2018-10-09 15:14:50
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Am Dienstag, den 09.10.2018, 16:54 +0200 schrieb Peter Eisentraut:
> On 06/10/2018 13:46, Michael Paquier wrote:
> > What do you think about the updated version attached?

> > +# Time to create a corruption

That looks a bit weird, maybe "some corupption"? Or maybe it's just me
not being a native speaker.

> Other than that, it appears to cover everything.

One more thing we could check is the relfilenode after we corrupted it,
it should also catch the corruption then. Or is that too trivial?


Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax: +49 2166 9901-100
Email: michael(dot)banck(at)credativ(dot)de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer

Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen:

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2018-10-09 15:16:04 Re: TupleTableSlot abstraction
Previous Message Peter Eisentraut 2018-10-09 14:54:44 Re: TAP tests for pg_verify_checksums