Re: Wrong dead return value in jsonb_utils.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Rikard Falkeborn <rikard(dot)falkeborn(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Wrong dead return value in jsonb_utils.c
Date: 2019-05-12 14:15:05
Message-ID: 15027.1557670505@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> As that's really cosmetic, I would just change that on HEAD, or
> perhaps others feel differently?

+1 for a HEAD-only change. I think the only really good arguments
for back-patching would be if this were causing compiler warnings
(but we've seen none) or if we thought it would likely lead to
hazards for back-patching future bug fixes (but the adjacent lines
seem unlikely to change).

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2019-05-12 14:49:07 Re: PG 12 draft release notes
Previous Message Bruce Momjian 2019-05-12 13:49:40 Re: PG 12 draft release notes