Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically
Date: 2017-01-18 12:38:03
Message-ID: 14917.1484743083@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Generate fmgr prototypes automatically

BTW, I notice some suspicious-looking behavior with -j:

$ make -j8 -s
Writing fmgroids.h
Writing fmgroids.h
Writing postgres.bki
Writing fmgrprotos.h
Writing fmgrtab.c
Writing schemapg.h
Writing postgres.description
Writing postgres.shdescription
Writing fmgrprotos.h
Writing fmgrtab.c
...

Why do fmgroids.h, fmgrprotos.h, and fmgrtab.c now get mentioned
twice? I suspect there is something broken about the parallelization.
If indeed multiple instances of gmake are writing these files
concurrently, that's likely to result in irreproducible build failures.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-01-18 14:36:08 pgsql: Add function to import operating system collations
Previous Message Tom Lane 2017-01-17 22:53:36 Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-01-18 13:03:18 Re: Parallel Index Scans
Previous Message Michael Paquier 2017-01-18 12:28:53 Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal