From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically |
Date: | 2017-01-17 22:53:36 |
Message-ID: | 12582.1484693616@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Alvaro Herrera wrote:
>> It is possible to replace many occurrences of builtins.h with
>> fmgrprotos.h. I just tried this
>> git grep -l 'include.*utils/builtins.h' -- *.c | xargs perl -pi -e 's{utils/builtins.h}{utils/fmgrprotos.h}'
>> There's a large number of changes that the oneliner produces that must
>> be reverted for the compile to be silent, but a large portion can
>> remain. (I only tried src/backend/access).
> 92 files are changed, 241 files still require builtins.h.
Let's hold off on that till we decide on the bigger-picture plan here.
If we're going to try to move those functions out of builtins.h,
this result will change considerably.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-01-18 12:38:03 | Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically |
Previous Message | Michael Paquier | 2017-01-17 22:18:14 | Re: Re: [COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2017-01-18 00:11:55 | Re: PoC: Grouped base relation |
Previous Message | Karl O. Pinc | 2017-01-17 22:36:32 | Re: Patch to implement pg_current_logfile() function |