Re: REVIEW: EXPLAIN and nfiltered

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org, Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>
Subject: Re: REVIEW: EXPLAIN and nfiltered
Date: 2011-01-20 16:10:39
Message-ID: 14894.1295539839@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Jan 19, 2011 at 10:16 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>> This patch looked good, in general, to me. I added a few documentation
>> updates and a comment, but it's a very straight-forward patch as far as
>> I can tell. Passes all regressions and my additional testing.

> I have not looked at the code for this patch at all as yet, but just
> as a general user comment - I really, really want this. It's one of
> about, uh, two pieces of information that the EXPLAIN output doesn't
> give you that is incredibly important for troubleshooting.

What's the other one?

The main problem I've got with this patch is that there's no place to
shoehorn the information into the textual EXPLAIN format without
breaking a lot of expectations (and hence code --- it's insane to
imagine that any significant amount of client-side code has been
rewritten to make use of xml/json output yet). It would be nice to know
what other requests are likely to be coming down the pike before we
decide exactly how we're going to break things.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2011-01-20 16:17:01 Re: ALTER TABLE ... REPLACE WITH
Previous Message Tom Lane 2011-01-20 16:00:41 Re: pg_basebackup for streaming base backups