Re: Keep ECPG comment for log_min_duration_statement

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: "Okano, Naoki" <okano(dot)naoki(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Keep ECPG comment for log_min_duration_statement
Date: 2017-02-27 11:36:40
Message-ID: 1488195400.16046.34.camel@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Michael Meskes wrote:
> > The other option I can see, albeit without looking into details, is
> > allowing all comments and then testing it for the right syntax
> > after
> > parsing. This could potentially also solve the above mentioned
> > option
> > problem.
>
> This idea sounds great. But I am not sure that I can understand it
> correctly.
>
> I understood the concept of this idea as following. Is it right?
> 1. The parser ignores comments/*...*/ as usual. That is, parser does
> not 
>    identify comments as a token. 

I guess it'd be easier to accept each comment as a token and then parse
the token text afterwards.

> 2. After parsing, we parse again only to extract comments.

Not sure if we can do that without creating a lot of overhead.

Michael

--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-02-27 11:44:13 Re: Documentation improvements for partitioning
Previous Message Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= 2017-02-27 11:34:23 Re: [PATCH] Add tab completion for DEALLOCATE