Re: Keep ECPG comment for log_min_duration_statement

From: "Okano, Naoki" <okano(dot)naoki(at)jp(dot)fujitsu(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: Keep ECPG comment for log_min_duration_statement
Date: 2017-02-27 09:36:44
Message-ID: 0B4917A40C80E34BBEC4BE1A7A9AB7E27AB083@g01jpexmbkw05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Thank you for your kind advise!

Michael Meskes wrote:
> The other option I can see, albeit without looking into details, is
> allowing all comments and then testing it for the right syntax after
> parsing. This could potentially also solve the above mentioned option
> problem.
This idea sounds great. But I am not sure that I can understand it correctly.

I understood the concept of this idea as following. Is it right?
1. The parser ignores comments/*...*/ as usual. That is, parser does not
identify comments as a token.
2. After parsing, we parse again only to extract comments.
3. comments are put back or forth in SQL statement.

Okano Naoki

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2017-02-27 09:40:54 postgres_fdw: support parameterized foreign joins
Previous Message Artur Zakirov 2017-02-27 09:19:00 Re: Bug in to_timestamp().