| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb) |
| Date: | 2021-02-11 18:46:07 |
| Message-ID: | 1477976.1613069167@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> On Mon, Feb 8, 2021 at 7:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Ugh, no it isn't: even pretty recent clang releases only define
>> __GNUC__ as 4. It looks like we need a separate test on clang's
>> version. I looked at their version history and sanitizers seem
>> to have come in around clang 7, so I propose the attached (where
>> I worked a bit harder on the comment, too).
> Looks good to me. Thank you for revising!
Were you going to push this, or did you expect me to?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-02-11 20:06:03 | pgsql: Remove dead code in ECPGconnect(), and improve documentation. |
| Previous Message | Tom Lane | 2021-02-11 17:49:47 | pgsql: Simplify jsonfuncs.c code by using strtoint() not strtol(). |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-02-11 18:58:54 | Re: Allowing create database within transaction block |
| Previous Message | Tom Lane | 2021-02-11 18:32:53 | Re: Tightening up allowed custom GUC names |