Re: Tightening up allowed custom GUC names

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Tightening up allowed custom GUC names
Date: 2021-02-11 18:32:53
Message-ID: 1477413.1613068373@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On Tue, Feb 09, 2021 at 05:34:37PM -0500, Tom Lane wrote:
>> * A case could be made for tightening things up a lot more, and not
>> allowing anything that doesn't look like an identifier. I'm not
>> pushing for that, as it seems more likely to break existing
>> applications than the narrow restriction proposed here. But I could
>> live with it if people prefer that way.

> I'd prefer that. Characters like backslash, space, and double quote have
> significant potential to reveal bugs, while having negligible application
> beyond revealing bugs.

Any other opinions here? I'm hesitant to make such a change on the
basis of just one vote.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-02-11 18:46:07 Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
Previous Message Joshua Drake 2021-02-11 18:28:57 Re: Extensibility of the PostgreSQL wire protocol