Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
Date: 2022-07-04 05:57:22
Message-ID: 1467768.1656914242@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I wrote:
> To start with, just a few lines down in IdentifySystem() the column
> is filled using Int32GetDatum not Int64GetDatum. I will get some
> popcorn and await the opinions of the 32-bit buildfarm animals.

Didn't need to wait long:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=florican&dt=2022-07-04%2005%3A39%3A50

The other questions still stand.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-07-04 06:09:08 pgsql: Fix for change timeline field of IDENTIFY_SYSTEM to int8
Previous Message Tom Lane 2022-07-04 05:55:13 Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2022-07-04 05:59:22 Re: Probable memory leak with ECPG and AIX
Previous Message Tom Lane 2022-07-04 05:55:13 Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8