| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8 |
| Date: | 2022-07-04 05:55:13 |
| Message-ID: | 1467434.1656914113@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> Change timeline field of IDENTIFY_SYSTEM to int8
Surely this patch is far from complete?
To start with, just a few lines down in IdentifySystem() the column
is filled using Int32GetDatum not Int64GetDatum. I will get some
popcorn and await the opinions of the 32-bit buildfarm animals.
But what about whatever code is reading the output? And what if
that code isn't v16? I can't believe that we can make a wire
protocol change as summarily as this.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-04 05:57:22 | Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8 |
| Previous Message | Peter Eisentraut | 2022-07-04 05:38:57 | pgsql: Change timeline field of IDENTIFY_SYSTEM to int8 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-04 05:57:22 | Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8 |
| Previous Message | Peter Eisentraut | 2022-07-04 05:38:57 | pgsql: Change timeline field of IDENTIFY_SYSTEM to int8 |