Re: reducing isolation tests runtime

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: reducing isolation tests runtime
Date: 2018-01-24 23:46:59
Message-ID: 14481.1516837619@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On the subject of test total time, we could paralelize isolation tests.
> Right now "make check" in src/test/isolation takes 1:16 on my machine.
> Test "timeouts" takes full 40s of that, with nothing running in parallel
> -- the machine is completely idle.

BTW, one small issue there is that the reason the timeouts test is so
slow is that we have to use multi-second timeouts to be sure slower
buildfarm critters (eg valgrind animals) will get the expected results.
So I'm worried that if the machine isn't otherwise idle, we will get
random failures.

We could parallelize the rest of those tests and leave timeouts in its own
group. That cuts the payback a lot :-( but might still be worth doing.
Or maybe tweak things so that the buildfarm runs a serial schedule but
manual testing doesn't. Or we could debate how important the timeout
tests really are ... or think harder about how to make them reproducible.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-01-25 00:29:09 Re: [HACKERS] parallel.c oblivion of worker-startup failures
Previous Message Robert Haas 2018-01-24 23:37:57 Re: [HACKERS] parallel.c oblivion of worker-startup failures

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-01-25 04:02:28 Re: pgsql: Add parallel-aware hash joins.
Previous Message Tom Lane 2018-01-24 23:37:18 Re: pgsql: Add parallel-aware hash joins.