| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Removed unused import modules from tap tests |
| Date: | 2021-11-10 14:53:27 |
| Message-ID: | 1437810.1636556007@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 10 Nov 2021, at 13:37, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>> ..but I wonder what's the *benefit* of removing those includes. IOW, what's
>> the reason not to simply drop the patch?
> I think the value is mostly neatnikism, the actual effect on runtime is
> unlikely to be measureable. I won't argue against doing it, but I suspect
> we'll just slowly add a lot of these back as tests evolve making excercise
> less useful.
Yeah, that last was pretty much my reaction. I don't know enough about
Perl to be sure how much an unused import costs, but I suspect you're
right that it won't be measurable in context, considering that most of
these test scripts run at least one initdb.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-11-10 14:58:14 | Re: Extensible Rmgr for Table AMs |
| Previous Message | Robert Haas | 2021-11-10 14:52:06 | Re: removing global variable ThisTimeLineID |