| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Stark <gsstark(at)mit(dot)edu> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Theory of operation of collation patch |
| Date: | 2011-03-10 15:43:03 |
| Message-ID: | 14378.1299771783@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greg Stark <gsstark(at)mit(dot)edu> writes:
> Can you give an example of what a column definition would look like if
> you put the COLLATE clause in the <data type> in a way that wouldn't
> be parsed according to your plan?
Column definitions look and act the same. The point of the change is to
not accept COLLATE in all the places where type names are used that are
*not* column definition lists. The original patch accepted nonsense like
create cast (text collate "C" as text collate "de_DE") with ...
and we'd have had to do quite a lot of additional hacking to plug those
holes.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-03-10 15:43:30 | Re: pgindent (was Re: Header comments in the recently added files) |
| Previous Message | Robert Haas | 2011-03-10 15:36:09 | Re: Native XML |