| From: | Antonin Houska <ah(at)cybertec(dot)at> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net> |
| Subject: | Re: Adding REPACK [concurrently] |
| Date: | 2026-01-08 16:59:00 |
| Message-ID: | 141054.1767891540@localhost |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Antonin Houska <ah(at)cybertec(dot)at> wrote:
> Antonin Houska <ah(at)cybertec(dot)at> wrote:
>
> > Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> > > If we do indeed need this,
> > > then perhaps it should be done after ReorderBufferProcessXid().
> >
> > ... and after SnapBuildProcessChange(). Thus the changes being discussed here
> > should be removed from the patch. I'll do that in the next version. Thanks.
>
> Actually the check of XLH_DELETE_NO_LOGICAL should not be discarded. I think
> it should be added to DecodeDelete().
v29 tries to fix the problem.
Besides that, it reflects the recent Mihail's comments [1], [2].
[1]
https://www.postgresql.org/message-id/CADzfLwXp4c-MJx7yVDxAGNNxPbX4o9dqyivxavtHvmUsdXYqBQ@mail.gmail.com
[2] https://www.postgresql.org/message-id/CADzfLwWNz_jwi7KVOmJ9D97+zwxsiwDSqSUUJ9oqUCOqkbGnRA@mail.gmail.com
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
| Attachment | Content-Type | Size |
|---|---|---|
| v29-0001-Add-REPACK-command.patch | text/x-diff | 144.5 KB |
| v29-0002-Refactor-index_concurrently_create_copy-for-use-with.patch | text/x-diff | 10.2 KB |
| v29-0003-Move-conversion-of-a-historic-to-MVCC-snapshot-to-a-.patch | text/x-diff | 5.5 KB |
| v29-0004-Add-CONCURRENTLY-option-to-REPACK-command.patch | text/plain | 145.6 KB |
| v29-0005-Use-background-worker-to-do-logical-decoding.patch | text/x-diff | 65.7 KB |
| v29-0006-Use-multiple-snapshots-to-copy-the-data.patch | text/plain | 66.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-01-08 17:11:29 | Re: Use IsA() macro instead of nodeTag comparison |
| Previous Message | Andrey Borodin | 2026-01-08 16:49:31 | Re: GIN pageinspect support for entry tree and posting tree |