Re: GIN pageinspect support for entry tree and posting tree

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Roman Khapov <rkhapov(at)yandex-team(dot)ru>
Subject: Re: GIN pageinspect support for entry tree and posting tree
Date: 2026-01-08 16:49:31
Message-ID: 83BBD2B9-6DEF-42DE-9385-0B2BDC9533D3@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 8 Jan 2026, at 01:57, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> PFA v10

"Prelimitary cleaunup" has two typos. Also it seems that you used something that is not pgindent.
Looks like clang-format with default settings.

+ errdetail("Expected special size %d, got %d.",
+ (int) MAXALIGN(sizeof(GinPageOpaqueData)),
+ PageGetSpecialSize(page)));
I PageGetSpecialSize() returns uint16, maybe let's cast it to (int) too?

Besides this 2nd patch looks good to me.

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2026-01-08 16:59:00 Re: Adding REPACK [concurrently]
Previous Message Robert Haas 2026-01-08 16:37:51 Re: pg_plan_advice