| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, rui hua <365507506hua(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Revive line type |
| Date: | 2013-10-02 00:42:46 |
| Message-ID: | 1380674566.22785.16.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-rrreviewers |
On Wed, 2013-09-25 at 14:26 +0530, Jeevan Chalke wrote:
> So no issues from my side.
>
> However, do we still need this in close_pl() ?
>
> #ifdef NOT_USED
> if (FPeq(line->A, -1.0) && FPzero(line->B))
> { /* vertical */
> }
> #endif
No, that can be removed.
> Also close_sl, close_lb and dist_lb are NOT yet implemented. It will
> be good if we have those. But I don't think we should wait for those
> functions to be implemented.
Right, those are separate projects.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-10-02 00:59:34 | Re: information schema parameter_default implementation |
| Previous Message | Peter Eisentraut | 2013-10-02 00:30:07 | Re: Completing PL support for Event Triggers |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Chalke | 2013-10-03 12:20:50 | Re: [PATCH] Revive line type |
| Previous Message | Jeevan Chalke | 2013-09-25 08:56:17 | Re: [PATCH] Revive line type |