| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Hubert Zhang <zhubert(at)vmware(dot)com>, tsunakawa(dot)takay(at)fujitsu(dot)com, pgsql-hackers(at)postgresql(dot)org, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: Multiple hosts in connection string failed to failover in non-hot standby mode |
| Date: | 2021-06-09 16:05:10 |
| Message-ID: | 1372552.1623254710@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> ... I'd be okay with dropping that test; or maybe we could
> fix things so that the default case succeeds?
Here's a draft patch that renames regress_ecpg_user2 to ecpg2_regression,
which matches the name of one of the databases used, allowing the test
cases with defaulted database name to succeed. That gets rid of one of
the problematic diffs. As it stood, though, that meant that connect/test5
wasn't exercising the connection-failure code path at all, which didn't
seem like what we want. So I adjusted the second place that had been
failing to again fail on no-such-database, and stuck in gssencmode=disable
so that we shouldn't get any test diff on hamerkop.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| fix-ECPG-connection-tests-again.patch | text/x-diff | 14.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-06-09 16:16:55 | Re: [bug?] Missed parallel safety checks, and wrong parallel safety |
| Previous Message | Matthias van de Meent | 2021-06-09 15:42:34 | Re: pg14b1 stuck in lazy_scan_prune/heap_page_prune of pg_statistic |