Re: Remove Windows crash dump support?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove Windows crash dump support?
Date: 2015-12-22 15:46:14
Message-ID: 13677.1450799174@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Tue, Dec 22, 2015 at 3:53 PM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>>> Back in 2010 I submitted a small feature to allow the creation of
>>> minidumps when backends crashed; see
>>> commit dcb09b595f88a3bca6097a6acc17bf2ec935d55f .
>>> At the time Windows lacked useful support for postmortem debugging and
>>> crash-dump management in the operating system its self, especially for
>>> applications running as services. That has since improved considerably.

> In which version(s) of Windows was this improvement added? I think that's
> really the part that matters here, not necessarily which version of
> PostgreSQL.

Even if it's all good in recent Windows, the impression I have is that an
awful lot of people are still running older versions, so I'd be pretty
hesitant to just drop the code. Also, AFAICS it's pretty self-contained
and hence not much of a drag on development. Is there any positive reason
to remove it? If the native facilities on newer Windows are better,
maybe we should teach the crash handler to install itself only on older
versions?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Ignatov 2015-12-22 15:48:43 Re: Remove Windows crash dump support?
Previous Message Aleksander Alekseev 2015-12-22 15:39:53 Re: Patch: fix lock contention for HASHHDR.mutex