Re: buildfarm's typedefs list has gone completely nutso

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: buildfarm's typedefs list has gone completely nutso
Date: 2019-07-18 16:48:06
Message-ID: 13633.1563468486@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-07-18 11:27:49 -0400, Tom Lane wrote:
>> Before ack'ing this, I've been waiting around for komodoensis to update
>> its typedefs list, in the hopes that the last couple of bogus entries
>> would go away. It still hasn't, and I just realized from looking at its
>> config that you have it set to do so at most twice a week:

> Boosted to min_hours_since=24 for now.

OK, I see it's updated, and we now have a sane typedefs list again:

$ diff -u src/tools/pgindent/typedefs.list new
--- src/tools/pgindent/typedefs.list 2019-07-02 10:32:57.078918638 -0400
+++ new/typedefs.list 2019-07-18 12:45:22.533451991 -0400
@@ -674,6 +674,12 @@
FmgrBuiltin
FmgrHookEventType
FmgrInfo
+ForBothCellState
+ForBothState
+ForEachState
+ForFiveState
+ForFourState
+ForThreeState
ForeignDataWrapper
ForeignKeyCacheInfo
ForeignKeyOptInfo
@@ -2981,7 +2987,7 @@
leaf_item
line_t
lineno_t
-list_qsort_comparator
+list_sort_comparator
locale_t
locate_agg_of_level_context
locate_var_of_level_context
@@ -3150,6 +3156,7 @@
pullup_replace_vars_context
pushdown_safety_info
qsort_arg_comparator
+qsort_comparator
query_pathkeys_callback
radius_attribute
radius_packet

All of those changes are correct, so we're good. Thanks!

(I still think the buildfarm's dow filter is wrong though)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2019-07-18 16:55:43 Re: buildfarm's typedefs list has gone completely nutso
Previous Message Daniel Gustafsson 2019-07-18 16:17:54 Re: buildfarm's typedefs list has gone completely nutso