| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Commits 8de72b and 5457a1 (COPY FREEZE) |
| Date: | 2012-12-06 00:57:56 |
| Message-ID: | 1354755476.28666.44.camel@jdavis |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2012-12-05 at 19:43 -0500, Tom Lane wrote:
> From memory, the tqual.c code assumes that any tuple with XMIN_COMMITTED
> couldn't possibly be from its own transaction, and thus it doesn't make
> the tests that would be appropriate for a tuple that is from the current
> transaction. Maybe it's all right anyway (i.e. if we should always treat
> such a tuple as good) but I don't recall exactly what's tested in those
> paths.
Oh, I see, it probably warrants some more discussion. It seems like we
could solve these problems if we narrow the conditions enough.
Anyway, the partial revert looks good, and the commit message seems
appropriate (essentially, the code got ahead of the discussion).
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2012-12-06 01:44:58 | Re: WIP: store additional info in GIN index |
| Previous Message | Robert Haas | 2012-12-06 00:46:44 | Re: ALTER TABLE ... NOREWRITE option |