Re: [COMMITTERS] pgsql: Replace XLogRecPtr struct with a 64-bit integer.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: [COMMITTERS] pgsql: Replace XLogRecPtr struct with a 64-bit integer.
Date: 2012-06-25 03:16:19
Message-ID: 1340593234-sup-8872@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


Excerpts from Heikki Linnakangas's message of dom jun 24 12:22:30 -0400 2012:
> Replace XLogRecPtr struct with a 64-bit integer.
>
> This simplifies code that needs to do arithmetic on XLogRecPtrs.
>
> To avoid changing on-disk format of data pages, the LSN on data pages is
> still stored in the old format. That should keep pg_upgrade happy. However,
> we have XLogRecPtrs embedded in the control file, and in the structs that
> are sent over the replication protocol, so this changes breaks compatibility
> of pg_basebackup and server. I didn't do anything about this in this patch,
> per discussion on -hackers, the right thing to do would to be to change the
> replication protocol to be architecture-independent, so that you could use
> a newer version of pg_receivexlog, for example, against an older server
> version.

One commit in this series broke pg_upgrade, which depended on
pg_resetxlog output: "First log file id after reset".

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2012-06-25 12:47:18 pgsql: Fix warning for 64-bit literal on 32-bit build.
Previous Message Peter Eisentraut 2012-06-24 23:41:59 pgsql: Replace int2/int4 in C code with int16/int32

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-06-25 03:24:47 Re: foreign key locks
Previous Message Robert Haas 2012-06-25 02:04:05 Re: libpq compression