Re: IO in wrong state on riscv64

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, greg(at)burd(dot)me
Subject: Re: IO in wrong state on riscv64
Date: 2025-11-08 00:24:24
Message-ID: 1340546.1762561464@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Sat, Nov 8, 2025 at 1:03 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> You're a brave man to be pushing this into the last-ever release
>> of v13 with all of 12 hours remaining till code freeze. I don't
>> mind so much for the newer branches, but I'm feeling nervous
>> about the risk/reward ratio for v13.

> I figured "adding a no-op compiler barrier where we already believed
> there to be a compiler barrier and rely on it crucially" was pretty
> safe as these things go, but that's a good point about v13 and I can
> revert it in that one branch in a couple of hours if that's the
> consensus.

It looks fairly safe to me too, or I'd be pushing back harder.
Still, we routinely get burnt by things we push into a branch's
final release, so I think it's worth having a discussion about
whether this has any possible downsides.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Maxim Zibitsker 2025-11-08 02:15:22 Support allocating memory for large strings
Previous Message Andres Freund 2025-11-08 00:18:20 Re: contrib/pg_stat_tcpinfo