| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |
| Date: | 2020-03-11 04:51:47 |
| Message-ID: | 132dfa3d-d36a-a6d3-ceea-24620d9546a8@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/03/11 13:44, Amit Langote wrote:
> On Wed, Mar 11, 2020 at 3:39 AM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> On Tue, Mar 10, 2020 at 6:19 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>> Attached is the updated version of the patch.
>>
>> Would it perhaps be better to return NULL instead of 0 in the
>> statistics view if there is no data?
>
> NULL sounds better than 0.
Ok, I will make the patch that changes the view so that NULL is
returned instead of 0. I'm thinking to commit that patch
after applying the change of pg_basebackup client side first.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-03-11 04:53:47 | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |
| Previous Message | Amit Langote | 2020-03-11 04:44:52 | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |