| From: | David Geier <geidav(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: get rid of Pointer type, mostly |
| Date: | 2026-02-03 11:09:58 |
| Message-ID: | 130682f7-e9a7-4916-8e2d-711900d8ccee@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
>> Either way is fine by me. It just seemed like the majority of commenters
>> where in favor of keeping some type in the GIN code for readability.
>
> After further consideration, I think it is best to leave this alone as
> is. One particular problem is that Pointer is part of the documented
> API of GIN, and if we either remove it or rename it, then this would
> create a bunch of work for extensions to keep their code compiling
> across major versions.
That's a pity. It would have been a nice cleanup of some crufty code
that makes readability harder than needed. Seems like a simple rename
would be acceptable in the spirit of e.g. [1].
--
David Geier
[1]
https://www.postgresql.org/message-id/2273bc2a-045d-4a75-8584-7cd9396e5534%40eisentraut.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | KAZAR Ayoub | 2026-02-03 12:06:19 | Re: Speed up COPY FROM text/CSV parsing using SIMD |
| Previous Message | David Geier | 2026-02-03 11:03:34 | Re: Use correct collation in pg_trgm |