| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | David Geier <geidav(dot)pg(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: get rid of Pointer type, mostly |
| Date: | 2026-01-26 10:20:04 |
| Message-ID: | 9d4fb5e5-b1c5-4e56-865d-93ba6a390022@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08.12.25 12:27, David Geier wrote:
> On 08.12.2025 12:14, Peter Eisentraut wrote:
>> I was planning to proceed with Dagfinn's patch set. Here is what is
>> currently remaining of the patch series. I haven't fully processed
>> everyone's comments in this thread, so they might not be reflected in
>> these patches.
> Dagfinn's patch set turns Pointer into void *. I thought we had agreed
> to use something like GinExtraPointer in the GIN code (see my patch set).
>
> Either way is fine by me. It just seemed like the majority of commenters
> where in favor of keeping some type in the GIN code for readability.
After further consideration, I think it is best to leave this alone as
is. One particular problem is that Pointer is part of the documented
API of GIN, and if we either remove it or rename it, then this would
create a bunch of work for extensions to keep their code compiling
across major versions.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-01-26 10:26:11 | Re: Safer hash table initialization macro |
| Previous Message | Jelte Fennema-Nio | 2026-01-26 10:13:57 | meson: Make test output much more useful on failure (both in CI and locally) |