Re: Review: Fix snapshot taking inconsistencies

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>, Steve Singer <ssinger_pg(at)sympatico(dot)ca>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: Fix snapshot taking inconsistencies
Date: 2011-02-24 00:35:13
Message-ID: 1298507410-sup-7250@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Tom Lane's message of mié feb 23 19:39:23 -0300 2011:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Excerpts from Marko Tiikkaja's message of sáb ene 15 17:30:14 -0300 2011:
> >> On 2010-10-21 3:32 PM +0200, Marko Tiikkaja wrote:
> > <patch>
> >>
> >> Here's the patch rebased against the master. No code changes since the
> >> last patch I sent.
>
> > Having a look at this.
>
> My recollection is that this was pretty tightly coupled to the wCTE
> patch. I had been intending to review them together, and have just
> now come up for air enough to start doing that. Do you really want
> to review this one separately?

Dunno. If you're gonna pick it up I guess my time is best spent
elsewhere. There was some restructuring in code in postgres.c to be
done near this patch, which wasn't attacked at all by Marko AFAICS.
Maybe I should be looking at that instead.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Tiikkaja 2011-02-24 00:38:05 Re: Review: Fix snapshot taking inconsistencies
Previous Message Tom Lane 2011-02-24 00:31:21 Re: Review: Fix snapshot taking inconsistencies