Re: Debug message in RemoveOldXlogFiles

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Debug message in RemoveOldXlogFiles
Date: 2010-06-18 08:50:01
Message-ID: 1276851001.23257.81464.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2010-06-17 at 16:13 +0900, Fujii Masao wrote:
> Hi,
>
> In the following debug message in RemoveOldXlogFiles(), the variables
> "log" and "seg" don't indicate LSN, so we should use %u instead of %X?
>
> elog(DEBUG2, "removing WAL segments older than %X/%X", log, seg);
>
> I attached the patch to do so.

I think it would be more helpful if it showed a filename. Shall we
change that?

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Training and Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-06-18 08:51:16 Re: debug log in pg_archivecleanup
Previous Message Magnus Hagander 2010-06-18 08:49:00 Re: system views for walsender activity