Re: Debug message in RemoveOldXlogFiles

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Debug message in RemoveOldXlogFiles
Date: 2010-06-18 13:59:57
Message-ID: 11541.1276869597@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> I think it would be more helpful if it showed a filename. Shall we
> change that?

The point of the committed change was to make that message look like
every other one in xlog.c that shows a log/seg pair.

If we were going to start redesigning the printout format, I'd
personally vote for something that makes it easier to compare LSN
printouts and log/seg printouts, like maybe printing log/seg as the
file's starting LSN. But the main point is that considering any one of
these messages in isolation is the wrong approach. In any case it's a
bit late to be bikeshedding this for 9.0.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-06-18 14:21:52 Re: system views for walsender activity
Previous Message Heikki Linnakangas 2010-06-18 12:50:59 Re: system views for walsender activity