Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,
Date: 2011-03-16 14:27:37
Message-ID: 12422.1300285657@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> How should recovery work when pause_at_recovery_target is
> enabled but hot standby is disabled? We have three choices:

> 1. Forbit those settings, i.e., throw FATAL error. Tom dislikes this
> idea.

No, I didn't say that. I said not to write elog(FATAL). If the
combination is nonsensical then it's fine to forbid it, but you don't
need FATAL for that. In particular, attempting to change to a
disallowed setting after system startup should not result in crashing
the postmaster. And it won't, if you just use the normal error level
for complaining about an invalid GUC setting.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2011-03-16 21:47:54 pgsql: Tab completion for \pset format and \pset linestyle.
Previous Message Robert Haas 2011-03-16 12:13:39 pgsql: Corrections to CREATE FOREIGN TABLE documentation.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-03-16 17:35:46 Re: Sync Rep and shutdown Re: Sync Rep v19
Previous Message Alvaro Herrera 2011-03-16 13:26:29 Re: Fwd: index corruption in PG 8.3.13