| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation. |
| Date: | 2017-03-14 03:43:13 |
| Message-ID: | 1206.1489462993@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> I don't mind the new output, but I kinda wonder whether it's a good idea
> to include the '.s.PGSQL.5432' bit in the host and/or whether we
> shouldn't include the port in the TCP cases as well
Yeah, I've been thinking that maybe it should look like
2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1", port 5432
2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv4 address "127.0.0.1", port 5432
2017-03-13 10:08:49.400 EDT [90059] LOG: listening on Unix address "/tmp/.s.PGSQL.5432"
It would take a couple more lines of code to make that happen, but
it would future-proof the messages against the day we decide to
allow one server to respond to more than one port number ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-03-14 06:18:43 | Re: [COMMITTERS] pgsql: Add test case for two phase commit. Also by Masahiko Sawada. |
| Previous Message | Andres Freund | 2017-03-14 03:38:42 | Re: [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-03-14 03:48:27 | Re: Write Ahead Logging for Hash Indexes |
| Previous Message | Andres Freund | 2017-03-14 03:38:42 | Re: [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation. |