Re: New ALTER OPERATOR command fails to update dependencies

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: New ALTER OPERATOR command fails to update dependencies
Date: 2015-12-31 22:30:33
Message-ID: 11889.1451601033@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> While this isn't exactly a stop-ship class of problem, it still seems like
>> it'd be good to fix before 9.5.0.

> I wonder if a note to packagers to inform them of the new file added
> after the RC would be a good idea.

On closer look, the busted ALTER OPERATOR functionality is only in HEAD
anyway.

But having said that, I wonder whether we ought not backpatch the header
file splitup anyhow. I observe that pg_operator.h's inclusion of
objectaddress.h is new in 9.5, and it sure looks to me like
objectaddress.h would be problematic for clients to include. So if
we don't do this, we might well get reports of client build failures.

(pg_operator.h is not the only catalog header that includes
objectaddress.h now, but it's the only one that does that and
seems like a plausible file for clients to include.)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-12-31 22:48:25 Re: IMPORT FOREIGN SCHEMA return create foreign table commands are those further filtered in LIMIT and EXCEPT cases?
Previous Message Chapman Flack 2015-12-31 21:49:27 Re: tracking owner of extension-managed objects