Re: Minimal logical decoding on standbys

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minimal logical decoding on standbys
Date: 2022-12-20 09:51:59
Message-ID: 117b962f-27d3-7ee9-bb2f-80a7e967c196@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 12/16/22 6:24 PM, Drouvot, Bertrand wrote:
> Hi,
>
> On 12/16/22 5:38 PM, Robert Haas wrote:
>> On Fri, Dec 16, 2022 at 10:08 AM Drouvot, Bertrand
>> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>>>> After 1489b1ce728 the name mayConflictInLogicalDecoding seems odd. Seems
>>>> it should be a riff on snapshotConflictHorizon?
>>>
>>> Gotcha, what about logicalSnapshotConflictThreat?
>>
>> logicalConflictPossible? checkDecodingConflict?
>>
>> I think we should try to keep this to three words if we can. There's
>> not likely to be enough value in a fourth word to make up for the
>> downside of being more verbose.
>>
>
>
> Yeah agree, I'd vote for logicalConflictPossible then.
>

Please find attached v33 using logicalConflictPossible as the new field name instead of mayConflictInLogicalDecoding.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v33-0006-Fixing-Walsender-corner-case-with-logical-decodi.patch text/plain 7.5 KB
v33-0005-Doc-changes-describing-details-about-logical-dec.patch text/plain 2.1 KB
v33-0004-New-TAP-test-for-logical-decoding-on-standby.patch text/plain 20.4 KB
v33-0003-Allow-logical-decoding-on-standby.patch text/plain 11.5 KB
v33-0002-Handle-logical-slot-conflicts-on-standby.patch text/plain 27.9 KB
v33-0001-Add-info-in-WAL-records-in-preparation-for-logic.patch text/plain 31.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message houzj.fnst@fujitsu.com 2022-12-20 10:14:49 RE: Perform streaming logical transactions by background workers and parallel apply
Previous Message David Rowley 2022-12-20 09:31:54 Re: Add enable_presorted_aggregate GUC