Re: Test-cases for exclusion constraints is missing in alter_table.sql file

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Test-cases for exclusion constraints is missing in alter_table.sql file
Date: 2018-01-17 18:30:20
Message-ID: 11791.1516213820@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> writes:
> While working on exclusion constraints for one of our internal
> project, I noticed that there is no test-case for exclusion
> constraints in alter_table.sql file. However, for other constraints i
> could see lots of test-cases in alter_table.sql. There are hardly 1-2
> test-cases for exclusion constraint using ALTER TABLE command (1 in
> constraints.source and 1 for partitioned table in alter_table.sql).
> Shouldn't we consider adding few test-cases for exclusion constraints
> in alter_table.sql considering that we have added lots of test-cases
> for other constraints in this file. Thoughts?

They're tested elsewhere, so this proposal seems rather duplicative.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2018-01-17 18:31:36 Re: [HACKERS] GnuTLS support
Previous Message Robert Haas 2018-01-17 18:27:59 Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)